Browse Source

Add user defined function to action.

core
tmk 11 years ago
parent
commit
4f274d125f
5 changed files with 54 additions and 50 deletions
  1. 23
    23
      common/action.c
  2. 24
    23
      common/action.h
  3. 1
    0
      common/keyboard.h
  4. 1
    1
      common/keymap.c
  5. 5
    3
      common/keymap.h

+ 23
- 23
common/action.c View File

@@ -110,7 +110,7 @@ static bool waiting_buffer_typed(keyevent_t event)
}
#endif

static bool waiting_buffer_has_anykey_pressed(void)
bool waiting_buffer_has_anykey_pressed(void)
{
for (uint8_t i = waiting_buffer_tail; i != waiting_buffer_head; i = (i + 1) % WAITING_BUFFER_SIZE) {
if (waiting_buffer[i].event.pressed) return true;
@@ -256,7 +256,7 @@ static void process_action(keyrecord_t *record)
debug("MODS_TAP: Oneshot: start\n");
oneshot_start(mods, event.time);
}
else if (tap_count == 5) {
else if (tap_count == TAPPING_TOGGLE) {
debug("MODS_TAP: Oneshot: toggle\n");
oneshot_toggle();
}
@@ -356,7 +356,7 @@ static void process_action(keyrecord_t *record)
switch (action.layer.code) {
case 0x00:
if (event.pressed) {
layer_switch(action.layer.opt);
layer_switch(action.layer.val);
}
//TODO: this is ok?
else {
@@ -367,19 +367,19 @@ static void process_action(keyrecord_t *record)
// tap toggle
if (event.pressed) {
if (tap_count < TAPPING_TOGGLE) {
layer_switch(action.layer.opt);
layer_switch(action.layer.val);
}
} else {
if (tap_count >= TAPPING_TOGGLE) {
debug("LAYER_PRESSED: tap toggle.\n");
layer_switch(action.layer.opt);
layer_switch(action.layer.val);
}
}
break;
case 0xFF:
// change default layer
if (event.pressed) {
default_layer = action.layer.opt;
default_layer = action.layer.val;
layer_switch(default_layer);
}
break;
@@ -391,7 +391,7 @@ static void process_action(keyrecord_t *record)
register_code(action.layer.code);
} else {
debug("LAYER_PRESSED: No tap: layer_switch\n");
layer_switch(action.layer.opt);
layer_switch(action.layer.val);
}
} else {
if (tap_count > 0) {
@@ -411,7 +411,7 @@ static void process_action(keyrecord_t *record)
switch (action.layer.code) {
case 0x00:
if (!event.pressed) {
layer_switch(action.layer.opt);
layer_switch(action.layer.val);
}
break;
case 0xF0:
@@ -419,18 +419,18 @@ static void process_action(keyrecord_t *record)
if (event.pressed) {
if (tap_count >= TAPPING_TOGGLE) {
debug("LAYER_RELEASED: tap toggle.\n");
layer_switch(action.layer.opt);
layer_switch(action.layer.val);
}
} else {
if (tap_count < TAPPING_TOGGLE) {
layer_switch(action.layer.opt);
layer_switch(action.layer.val);
}
}
break;
case 0xFF:
// change default layer
if (!event.pressed) {
default_layer = action.layer.opt;
default_layer = action.layer.val;
layer_switch(default_layer);
}
break;
@@ -449,7 +449,7 @@ static void process_action(keyrecord_t *record)
unregister_code(action.layer.code);
} else {
debug("LAYER_RELEASED: No tap: layer_switch\n");
layer_switch(action.layer.opt);
layer_switch(action.layer.val);
}
}
break;
@@ -459,9 +459,9 @@ static void process_action(keyrecord_t *record)
switch (action.layer.code) {
case 0x00:
if (event.pressed) {
layer_switch(current_layer ^ action.layer.opt);
layer_switch(current_layer ^ action.layer.val);
} else {
layer_switch(current_layer ^ action.layer.opt);
layer_switch(current_layer ^ action.layer.val);
}
break;
case 0xF0:
@@ -469,22 +469,22 @@ static void process_action(keyrecord_t *record)
if (event.pressed) {
if (tap_count < TAPPING_TOGGLE) {
debug("LAYER_BIT: tap toggle(press).\n");
layer_switch(current_layer ^ action.layer.opt);
layer_switch(current_layer ^ action.layer.val);
}
} else {
if (tap_count <= TAPPING_TOGGLE) {
debug("LAYER_BIT: tap toggle(release).\n");
layer_switch(current_layer ^ action.layer.opt);
layer_switch(current_layer ^ action.layer.val);
}
}
break;
case 0xFF:
// change default layer
if (event.pressed) {
default_layer = current_layer ^ action.layer.opt;
default_layer = current_layer ^ action.layer.val;
layer_switch(default_layer);
} else {
default_layer = current_layer ^ action.layer.opt;
default_layer = current_layer ^ action.layer.val;
layer_switch(default_layer);
}
break;
@@ -496,7 +496,7 @@ static void process_action(keyrecord_t *record)
register_code(action.layer.code);
} else {
debug("LAYER_BIT: No tap: layer_switch(bit on)\n");
layer_switch(current_layer ^ action.layer.opt);
layer_switch(current_layer ^ action.layer.val);
}
} else {
if (IS_TAPPING_KEY(event.key) && tap_count > 0) {
@@ -504,14 +504,14 @@ static void process_action(keyrecord_t *record)
unregister_code(action.layer.code);
} else {
debug("LAYER_BIT: No tap: layer_switch(bit off)\n");
layer_switch(current_layer ^ action.layer.opt);
layer_switch(current_layer ^ action.layer.val);
}
}
break;
}
break;
case ACT_LAYER_EXT:
switch (action.layer.opt) {
switch (action.layer.val) {
case 0x00:
// set default layer when pressed
switch (action.layer.code) {
@@ -620,7 +620,7 @@ static void process_action(keyrecord_t *record)
break;
case ACT_FUNCTION:
// TODO
action_call_function(event, action.func.id);
keymap_call_function(record, action.func.id);
break;
default:
break;
@@ -944,7 +944,7 @@ bool is_tap_key(key_t key)
}
return false;
case ACT_FUNCTION:
if (action.func.opt & 0x1) {
if (action.func.opt & O_TAP) {
return true;
}
return false;

+ 24
- 23
common/action.h View File

@@ -21,6 +21,16 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#include "keycode.h"


/* Execute action per keyevent */
void action_exec(keyevent_t event);


/* Struct to record event and tap count */
typedef struct {
keyevent_t event;
uint8_t tap_count;
} keyrecord_t;

/* Action struct.
*
* In avr-gcc bit field seems to be assigned from LSB(bit0) to MSB(bit15).
@@ -48,7 +58,7 @@ typedef union {
} key;
struct action_layer {
uint16_t code :8;
uint16_t opt :4;
uint16_t val :4;
uint16_t kind :4;
} layer;
struct action_usage {
@@ -58,7 +68,7 @@ typedef union {
} usage;
struct action_command {
uint16_t id :8;
uint16_t option :4;
uint16_t opt :4;
uint16_t kind :4;
} command;
struct action_function {
@@ -68,18 +78,6 @@ typedef union {
} func;
} action_t;

/* Struct to record action and tap count */
typedef struct {
keyevent_t event;
uint8_t tap_count;
} keyrecord_t;


/* execute action per keyevent */
void action_exec(keyevent_t event);
typedef void (*action_func_t)(keyevent_t event, uint8_t opt); // TODO:no need?
void action_call_function(keyevent_t event, uint8_t id); // TODO: action function


/*
* Utilities for actions.
@@ -94,6 +92,7 @@ void clear_keyboard_but_mods(void);
bool sending_anykey(void);
void layer_switch(uint8_t new_layer);
bool is_tap_key(key_t key);
bool waiting_buffer_has_anykey_pressed(void);



@@ -203,9 +202,6 @@ ACT_FUNCTION(1111):
1111| address(12) Function?
1111|opt | id(8) Function?

TODO: modifier + function by tap?
for example: LShift + '('[Shift+9] and RShift + ')'[Shift+0]
http://deskthority.net/workshop-f7/tmk-keyboard-firmware-collection-t4478.html#p90052
*/
enum action_kind_id {
ACT_LMODS = 0b0000,
@@ -226,8 +222,12 @@ enum action_kind_id {
ACT_FUNCTION = 0b1111
};

enum acion_param {
ONE_SHOT = 0x00,
enum params {
P_ONESHOT = 0x00,
};

enum options {
O_TAP = 0x8,
};


@@ -251,14 +251,14 @@ enum acion_param {

/* Mods + Tap key */
#define ACTION_LMODS_TAP_KEY(mods, key) ACTION(ACT_LMODS_TAP, MODS4(mods)<<8 | (key))
#define ACTION_LMODS_ONESHOT(mods) ACTION(ACT_LMODS_TAP, MODS4(mods)<<8 | ONE_SHOT)
#define ACTION_LMODS_ONESHOT(mods) ACTION(ACT_LMODS_TAP, MODS4(mods)<<8 | P_ONESHOT)
#define ACTION_RMODS_TAP_KEY(mods, key) ACTION(ACT_RMODS_TAP, MODS4(mods)<<8 | (key))
#define ACTION_RMODS_ONESHOT(mods) ACTION(ACT_RMODS_TAP, MODS4(mods)<<8 | ONE_SHOT)
#define ACTION_RMODS_ONESHOT(mods) ACTION(ACT_RMODS_TAP, MODS4(mods)<<8 | P_ONESHOT)
/* Mod + Tap key */
#define ACTION_LMOD_TAP_KEY(mod, key) ACTION(ACT_LMODS_TAP, MODS4(MOD_BIT(mod))<<8 | (key))
#define ACTION_LMOD_ONESHOT(mod) ACTION(ACT_LMODS_TAP, MODS4(MOD_BIT(mod))<<8 | ONE_SHOT)
#define ACTION_LMOD_ONESHOT(mod) ACTION(ACT_LMODS_TAP, MODS4(MOD_BIT(mod))<<8 | P_ONESHOT)
#define ACTION_RMOD_TAP_KEY(mod, key) ACTION(ACT_RMODS_TAP, MODS4(MOD_BIT(mod))<<8 | (key))
#define ACTION_RMOD_ONESHOT(mod) ACTION(ACT_RMODS_TAP, MODS4(MOD_BIT(mod))<<8 | ONE_SHOT)
#define ACTION_RMOD_ONESHOT(mod) ACTION(ACT_RMODS_TAP, MODS4(MOD_BIT(mod))<<8 | P_ONESHOT)

// TODO: contemplate about layer action
/* Switch current layer */
@@ -304,5 +304,6 @@ enum acion_param {

/* Function */
#define ACTION_FUNCTION(id, opt) ACTION(ACT_FUNCTION, (opt)<<8 | id)
#define ACTION_FUNCTION_TAP(id) ACTION(ACT_FUNCTION, O_TAP<<8 | id)

#endif /* ACTION_H */

+ 1
- 0
common/keyboard.h View File

@@ -32,6 +32,7 @@ typedef struct {
uint8_t row;
} keypos_t;

// TODO: need raw? keypos_t -> key_t?
typedef union {
uint16_t raw;
keypos_t pos;

+ 1
- 1
common/keymap.c View File

@@ -68,6 +68,6 @@ action_t keymap_get_action(uint8_t layer, uint8_t row, uint8_t col)
#endif

__attribute__ ((weak))
void action_call_function(keyevent_t event, uint8_t id)
void keymap_call_function(keyrecord_t *event, uint8_t id)
{
}

+ 5
- 3
common/keymap.h View File

@@ -29,11 +29,13 @@ extern uint8_t current_layer;
extern uint8_t default_layer;


/*
* new keymap interface: action
*/
/* action for key */
// TODO: should use struct key_t?
action_t keymap_get_action(uint8_t layer, uint8_t row, uint8_t col);

/* user defined special function */
void keymap_call_function(keyrecord_t *record, uint8_t id);


#ifndef NO_LEGACY_KEYMAP_SUPPORT
/* keycode of key */